Re: [PATCH v4 12/10] git-remote-testgit: support the new 'force' option

2013-11-11 Thread Richard Hansen
On 2013-11-11 13:28, Junio C Hamano wrote: > Richard Hansen writes: > >>> I think the convention is to align these: >>> >>> case $opt in >>> force) >> >> The existing case statement in this file indents the patterns the same >> amount as the case statement, so this should be aligned to match. >>

Re: [PATCH v4 12/10] git-remote-testgit: support the new 'force' option

2013-11-11 Thread Junio C Hamano
Richard Hansen writes: >> I think the convention is to align these: >> >> case $opt in >> force) > > The existing case statement in this file indents the patterns the same > amount as the case statement, so this should be aligned to match. > > In general I rarely see the case patterns indented a

Re: [PATCH v4 12/10] git-remote-testgit: support the new 'force' option

2013-11-10 Thread Felipe Contreras
On Sun, Nov 10, 2013 at 4:46 PM, Richard Hansen wrote: > On 2013-10-29 04:41, Felipe Contreras wrote: >> Richard Hansen wrote: >>> Signed-off-by: Richard Hansen >>> --- >>> git-remote-testgit.sh | 18 ++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/git-remote-testgit

Re: [PATCH v4 12/10] git-remote-testgit: support the new 'force' option

2013-11-10 Thread Richard Hansen
On 2013-10-29 04:41, Felipe Contreras wrote: > Richard Hansen wrote: >> Signed-off-by: Richard Hansen >> --- >> git-remote-testgit.sh | 18 ++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/git-remote-testgit.sh b/git-remote-testgit.sh >> index 6d2f282..80546c1 100755 >> -

RE: [PATCH v4 12/10] git-remote-testgit: support the new 'force' option

2013-10-29 Thread Felipe Contreras
Richard Hansen wrote: > Signed-off-by: Richard Hansen > --- > git-remote-testgit.sh | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/git-remote-testgit.sh b/git-remote-testgit.sh > index 6d2f282..80546c1 100755 > --- a/git-remote-testgit.sh > +++ b/git-remote-testgit.

[PATCH v4 12/10] git-remote-testgit: support the new 'force' option

2013-10-27 Thread Richard Hansen
Signed-off-by: Richard Hansen --- git-remote-testgit.sh | 18 ++ 1 file changed, 18 insertions(+) diff --git a/git-remote-testgit.sh b/git-remote-testgit.sh index 6d2f282..80546c1 100755 --- a/git-remote-testgit.sh +++ b/git-remote-testgit.sh @@ -6,6 +6,7 @@ url=$2 dir="$GIT_D