Re: [PATCH v4 11/32] delete_ref_loose(): don't muck around in the lock_file's filename

2014-09-14 Thread Johannes Sixt
Am 14.09.2014 um 08:38 schrieb Michael Haggerty: > On 09/14/2014 08:27 AM, Michael Haggerty wrote: >> On 09/13/2014 09:41 AM, Johannes Sixt wrote: >>> Am 06.09.2014 um 09:50 schrieb Michael Haggerty: It's bad manners. Especially since, if unlink_or_warn() failed, the memory wasn't restor

Re: [PATCH v4 11/32] delete_ref_loose(): don't muck around in the lock_file's filename

2014-09-13 Thread Michael Haggerty
On 09/14/2014 08:27 AM, Michael Haggerty wrote: > On 09/13/2014 09:41 AM, Johannes Sixt wrote: >> Am 06.09.2014 um 09:50 schrieb Michael Haggerty: >>> It's bad manners. Especially since, if unlink_or_warn() failed, the >>> memory wasn't restored to its original contents. >> >> I do not see how the

Re: [PATCH v4 11/32] delete_ref_loose(): don't muck around in the lock_file's filename

2014-09-13 Thread Michael Haggerty
On 09/13/2014 09:41 AM, Johannes Sixt wrote: > Am 06.09.2014 um 09:50 schrieb Michael Haggerty: >> It's bad manners. Especially since, if unlink_or_warn() failed, the >> memory wasn't restored to its original contents. > > I do not see how the old code did not restore the file name. Except for >

Re: [PATCH v4 11/32] delete_ref_loose(): don't muck around in the lock_file's filename

2014-09-13 Thread Johannes Sixt
Am 06.09.2014 um 09:50 schrieb Michael Haggerty: > It's bad manners. Especially since, if unlink_or_warn() failed, the > memory wasn't restored to its original contents. I do not see how the old code did not restore the file name. Except for this nit, the patch looks good. > > So make our own c

[PATCH v4 11/32] delete_ref_loose(): don't muck around in the lock_file's filename

2014-09-06 Thread Michael Haggerty
It's bad manners. Especially since, if unlink_or_warn() failed, the memory wasn't restored to its original contents. So make our own copy to work with. Signed-off-by: Michael Haggerty --- refs.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/refs.c b/refs.c