"brian m. carlson" writes:
> I need to do a reroll to address some other issues people brought up, so
> I can remove this line.
OK. I actually do not feel too strongly about this one, by the way.
On Mon, Oct 29, 2018 at 09:39:33AM +0900, Junio C Hamano wrote:
> "brian m. carlson" writes:
> > This may not strictly be needed, but removing it makes the header no
> > longer self-contained, which blows up my (and others') in-editor
> > linting.
>
> That sounds like bending backwards to please
"brian m. carlson" writes:
>> > +
>> > +#include "git-compat-util.h"
>>
>> this shouldn't be needed and might be discouraged as per the
>> instructions in Documentation/CodingGuidelines
>
> This may not strictly be needed, but removing it makes the header no
> longer self-contained, which blows
On Wed, Oct 24, 2018 at 08:02:55PM -0700, Carlo Arenas wrote:
> On Wed, Oct 24, 2018 at 7:41 PM brian m. carlson
> wrote:
> > diff --git a/sha256/block/sha256.h b/sha256/block/sha256.h
> > new file mode 100644
> > index 00..38f02f7e6c
> > --- /dev/null
> > +++ b/sha256/block/sha256.h
> > @
On Thu, Oct 25, 2018 at 4:42 AM brian m. carlson
wrote:
> +static void blk_SHA256_Transform(blk_SHA256_CTX *ctx, const unsigned char
> *buf)
> +{
> +
> + uint32_t S[8], W[64], t0, t1;
> + int i;
> +
> + /* copy state into S */
> + for (i = 0; i < 8; i++) {
> +
On Wed, Oct 24, 2018 at 7:41 PM brian m. carlson
wrote:
> diff --git a/sha256/block/sha256.h b/sha256/block/sha256.h
> new file mode 100644
> index 00..38f02f7e6c
> --- /dev/null
> +++ b/sha256/block/sha256.h
> @@ -0,0 +1,26 @@
> +#ifndef SHA256_BLOCK_SHA256_H
> +#define SHA256_BLOCK_SHA25
SHA-1 is weak and we need to transition to a new hash function. For
some time, we have referred to this new function as NewHash. Recently,
we decided to pick SHA-256 as NewHash.
Add a basic implementation of SHA-256 based off libtomcrypt, which is in
the public domain. Optimize it and restructu
7 matches
Mail list logo
