Re: [PATCH v4 1/7] t/README: reformat Do, Don't, Keep in mind lists

2018-10-05 Thread Matthew DeVore
On Thu, Oct 4, 2018 at 11:15 PM Junio C Hamano wrote: > > Matthew DeVore writes: > > > -Do's, don'ts & things to keep in mind > > +Do's & don'ts > > - > > We may not format this with AsciiDoc, but please shorten the > underline so that it aligns with the line

Re: [PATCH v4 1/7] t/README: reformat Do, Don't, Keep in mind lists

2018-10-04 Thread Junio C Hamano
Matthew DeVore writes: > diff --git a/t/README b/t/README > index 9028b47d9..85024aba6 100644 > --- a/t/README > +++ b/t/README > @@ -393,13 +393,13 @@ This test harness library does the following things: > consistently when command line arguments --verbose (or -v), > --debug (or -d), and

[PATCH v4 1/7] t/README: reformat Do, Don't, Keep in mind lists

2018-10-03 Thread Matthew DeVore
The list of Don'ts for test writing has grown large such that it is hard to see at a glance which section an item is in. In other words, if I ignore a little bit of surrounding context, the "don'ts" look like "do's." To make the list more readable, prefix "Don't" in front of every first sentence i