Re: [PATCH v4 1/6] worktree.c: add find_worktree()

2016-06-13 Thread Duy Nguyen
On Fri, Jun 3, 2016 at 10:00 PM, Ramsay Jones wrote: > > > On 03/06/16 13:19, Nguyễn Thái Ngọc Duy wrote: >> So far we haven't needed to identify an existing worktree from command >> line. Future commands such as lock or move will need it. The current >> implementation identifies worktrees by path

Re: [PATCH v4 1/6] worktree.c: add find_worktree()

2016-06-03 Thread Ramsay Jones
On 03/06/16 13:19, Nguyễn Thái Ngọc Duy wrote: > So far we haven't needed to identify an existing worktree from command > line. Future commands such as lock or move will need it. The current > implementation identifies worktrees by path (*). In future, the function > could learn to identify by $(

[PATCH v4 1/6] worktree.c: add find_worktree()

2016-06-03 Thread Nguyễn Thái Ngọc Duy
So far we haven't needed to identify an existing worktree from command line. Future commands such as lock or move will need it. The current implementation identifies worktrees by path (*). In future, the function could learn to identify by $(basename $path) or tags... (*) We could probably go chea