Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-23 Thread Karthik Nayak
On Tue, Jun 23, 2015 at 4:08 AM, Eric Sunshine wrote: > On Sun, Jun 21, 2015 at 4:48 PM, Karthik Nayak wrote: >> Add the '--points-at' option provided by 'ref-filter'. The >> option lets the user to pick only refs which point to a particular >> commit. >> >> Add documentation and tests for the sa

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-22 Thread Eric Sunshine
On Sun, Jun 21, 2015 at 4:48 PM, Karthik Nayak wrote: > Add the '--points-at' option provided by 'ref-filter'. The > option lets the user to pick only refs which point to a particular > commit. > > Add documentation and tests for the same. > > Based-on-patch-by: Jeff King > Mentored-by: Christian

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-22 Thread Junio C Hamano
Junio C Hamano writes: >> I have a slight preference for keeping the pairs not squashed. This way, >> we have a clear separation "write reusable library code" / "use it". But >> I'm fine with squashing if others prefer. > > As I cannot firmly say that "copy & paste first and then later > clean-up

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-22 Thread Karthik Nayak
On Tue, Jun 23, 2015 at 12:54 AM, Junio C Hamano wrote: > Matthieu Moy writes: > >> Karthik Nayak writes: >> >>> On Mon, Jun 22, 2015 at 6:15 AM, Junio C Hamano wrote: 3 & 4 as a single patch may make more sense, if we were to tolerate the "let's copy & paste first and then later rem

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-22 Thread Junio C Hamano
Matthieu Moy writes: > Karthik Nayak writes: > >> On Mon, Jun 22, 2015 at 6:15 AM, Junio C Hamano wrote: >>> 3 & 4 as a single patch may make more sense, if we were to tolerate the >>> "let's copy & paste first and then later remove the duplicate" as a way to >>> postpone touching "tag.c" side

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-22 Thread Matthieu Moy
Karthik Nayak writes: > On Mon, Jun 22, 2015 at 6:15 AM, Junio C Hamano wrote: >> 3 & 4 as a single patch may make more sense, if we were to tolerate the >> "let's copy & paste first and then later remove the duplicate" as a way to >> postpone touching "tag.c" side in order to first concentrate

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-22 Thread Karthik Nayak
On Mon, Jun 22, 2015 at 6:15 AM, Junio C Hamano wrote: > 3 & 4 as a single patch may make more sense, if we were to tolerate the > "let's copy & paste first and then later remove the duplicate" as a way to > postpone touching "tag.c" side in order to first concentrate on for-each-ref. > > I have

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-21 Thread Junio C Hamano
3 & 4 as a single patch may make more sense, if we were to tolerate the "let's copy & paste first and then later remove the duplicate" as a way to postpone touching "tag.c" side in order to first concentrate on for-each-ref. I have not formed a firm opinion on what the right split of the series i

[PATCH v4 04/19] for-each-ref: add '--points-at' option

2015-06-21 Thread Karthik Nayak
Add the '--points-at' option provided by 'ref-filter'. The option lets the user to pick only refs which point to a particular commit. Add documentation and tests for the same. Based-on-patch-by: Jeff King Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak ---