Re: [PATCH v4 04/14] Add new simplified git-remote-testgit

2012-11-02 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 5:03 PM, Stefano Lattarini wrote: > On 11/02/2012 04:42 PM, Felipe Contreras wrote: >> What happens when you call this with: >> >> ./script "alias with spaces" >> > '$alias' will correctly expand to "alias with spaces". Try out: > > $ sh -c 'alias=$1; echo "$alias"' dum

Re: [PATCH v4 04/14] Add new simplified git-remote-testgit

2012-11-02 Thread Stefano Lattarini
On 11/02/2012 04:42 PM, Felipe Contreras wrote: > On Fri, Nov 2, 2012 at 2:55 PM, Stefano Lattarini > wrote: > >>> +#!/bin/bash >>> >> I think git can't assume the existence of bash unconditionally, neither >> in its scripts, nor in its tests (the exception being the tests on >> bash completion,

Re: [PATCH v4 04/14] Add new simplified git-remote-testgit

2012-11-02 Thread Felipe Contreras
On Fri, Nov 2, 2012 at 2:55 PM, Stefano Lattarini wrote: >> +#!/bin/bash >> > I think git can't assume the existence of bash unconditionally, neither > in its scripts, nor in its tests (the exception being the tests on > bash completion, of course). This script probably need to be re-written > t

Re: [PATCH v4 04/14] Add new simplified git-remote-testgit

2012-11-02 Thread Jeff King
On Fri, Nov 02, 2012 at 02:55:41PM +0100, Stefano Lattarini wrote: > > --- /dev/null > > +++ b/git-remote-testgit > > @@ -0,0 +1,62 @@ > > +#!/bin/bash > > > I think git can't assume the existence of bash unconditionally, neither > in its scripts, nor in its tests (the exception being the tests on

Re: [PATCH v4 04/14] Add new simplified git-remote-testgit

2012-11-02 Thread Stefano Lattarini
On 11/02/2012 03:02 AM, Felipe Contreras wrote: > It's way simpler. It exerceises the same features of remote helpers. > It's easy to read and understand. It doesn't depend on python. > > It does _not_ exercise the python remote helper framework; there's > another tool and another test for that. >

[PATCH v4 04/14] Add new simplified git-remote-testgit

2012-11-01 Thread Felipe Contreras
It's way simpler. It exerceises the same features of remote helpers. It's easy to read and understand. It doesn't depend on python. It does _not_ exercise the python remote helper framework; there's another tool and another test for that. For now let's just copy the old remote-helpers test script