Re: [PATCH v4 04/11] replace: "libify" create_graft() and callees

2018-04-25 Thread Johannes Schindelin
Hi Stefan, On Tue, 24 Apr 2018, Stefan Beller wrote: > On Tue, Apr 24, 2018 at 11:51 AM, Johannes Schindelin > wrote: > > > > > Oy vey. How many more mistakes can I introduce in one commit... > > > > I ask this myself all the time, but Software is hard when not having > computer assisted check

Re: [PATCH v4 04/11] replace: "libify" create_graft() and callees

2018-04-24 Thread Stefan Beller
Hi Johannes, On Tue, Apr 24, 2018 at 11:51 AM, Johannes Schindelin wrote: > > Oy vey. How many more mistakes can I introduce in one commit... > I ask this myself all the time, but Software is hard when not having computer assisted checks. The test suite doesn't quite count here, as it doesn't y

Re: [PATCH v4 04/11] replace: "libify" create_graft() and callees

2018-04-24 Thread Johannes Schindelin
Hi Stefan, On Mon, 23 Apr 2018, Stefan Beller wrote: > On Fri, Apr 20, 2018 at 3:21 PM, Johannes Schindelin > wrote: > > @@ -250,27 +257,38 @@ static void import_object(struct object_id *oid, enum > > object_type type, > > - if (strbuf_read(&result, cmd.out, 41) < 0) > > -

Re: [PATCH v4 04/11] replace: "libify" create_graft() and callees

2018-04-23 Thread Stefan Beller
Hi Johannes, On Fri, Apr 20, 2018 at 3:21 PM, Johannes Schindelin wrote: > @@ -250,27 +257,38 @@ static void import_object(struct object_id *oid, enum > object_type type, > - if (strbuf_read(&result, cmd.out, 41) < 0) > - die_errno("unable to read from mktree"

[PATCH v4 04/11] replace: "libify" create_graft() and callees

2018-04-21 Thread Johannes Schindelin
File this away as yet another patch in the "libification" category. As with all useful functions, in the next commit we want to use create_graft() from a higher-level function where it would be inconvenient if the called function simply die()s: if there is a problem, we want to let the user know h