Re: [PATCH v4 02/16] refs.c: use is_dir_sep() in resolve_gitlink_ref()

2017-09-06 Thread Stefan Beller
On Wed, Sep 6, 2017 at 4:08 AM, Duy Nguyen wrote: > On Thu, Aug 24, 2017 at 2:14 AM, Stefan Beller wrote: >> On Wed, Aug 23, 2017 at 5:36 AM, Nguyễn Thái Ngọc Duy >> wrote: >>> The "submodule" argument in this function is a path, which can have >>> either '/' or '\\' as a separator. Use is_dir_

Re: [PATCH v4 02/16] refs.c: use is_dir_sep() in resolve_gitlink_ref()

2017-09-06 Thread Duy Nguyen
On Thu, Aug 24, 2017 at 2:14 AM, Stefan Beller wrote: > On Wed, Aug 23, 2017 at 5:36 AM, Nguyễn Thái Ngọc Duy > wrote: >> The "submodule" argument in this function is a path, which can have >> either '/' or '\\' as a separator. Use is_dir_sep() to support both. >> >> Noticed-by: Johannes Sixt >

Re: [PATCH v4 02/16] refs.c: use is_dir_sep() in resolve_gitlink_ref()

2017-08-23 Thread Stefan Beller
On Wed, Aug 23, 2017 at 5:36 AM, Nguyễn Thái Ngọc Duy wrote: > The "submodule" argument in this function is a path, which can have > either '/' or '\\' as a separator. Use is_dir_sep() to support both. > > Noticed-by: Johannes Sixt > Signed-off-by: Nguyễn Thái Ngọc Duy Immediate questions that

[PATCH v4 02/16] refs.c: use is_dir_sep() in resolve_gitlink_ref()

2017-08-23 Thread Nguyễn Thái Ngọc Duy
The "submodule" argument in this function is a path, which can have either '/' or '\\' as a separator. Use is_dir_sep() to support both. Noticed-by: Johannes Sixt Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/refs.c b/refs.c i