Re: [PATCH v4 02/16] Report bugs consistently

2016-07-26 Thread Johannes Schindelin
Hi Junio & Peff, On Mon, 25 Jul 2016, Junio C Hamano wrote: > Jeff King writes: > > > On Mon, Jul 25, 2016 at 02:44:25PM -0700, Junio C Hamano wrote: > > > >> > diff --git a/imap-send.c b/imap-send.c > >> > index db0fafe..67d67f8 100644 > >> > --- a/imap-send.c > >> > +++ b/imap-send.c > >> > @

Re: [PATCH v4 02/16] Report bugs consistently

2016-07-25 Thread Junio C Hamano
Jeff King writes: > On Mon, Jul 25, 2016 at 02:44:25PM -0700, Junio C Hamano wrote: > >> > diff --git a/imap-send.c b/imap-send.c >> > index db0fafe..67d67f8 100644 >> > --- a/imap-send.c >> > +++ b/imap-send.c >> > @@ -506,12 +506,12 @@ static char *next_arg(char **s) >> > >> > static int nfs

Re: [PATCH v4 02/16] Report bugs consistently

2016-07-25 Thread Jeff King
On Mon, Jul 25, 2016 at 02:44:25PM -0700, Junio C Hamano wrote: > > diff --git a/imap-send.c b/imap-send.c > > index db0fafe..67d67f8 100644 > > --- a/imap-send.c > > +++ b/imap-send.c > > @@ -506,12 +506,12 @@ static char *next_arg(char **s) > > > > static int nfsnprintf(char *buf, int blen, c

Re: [PATCH v4 02/16] Report bugs consistently

2016-07-25 Thread Junio C Hamano
Johannes Schindelin writes: > diff --git a/imap-send.c b/imap-send.c > index db0fafe..67d67f8 100644 > --- a/imap-send.c > +++ b/imap-send.c > @@ -506,12 +506,12 @@ static char *next_arg(char **s) > > static int nfsnprintf(char *buf, int blen, const char *fmt, ...) > { > - int ret; > +

[PATCH v4 02/16] Report bugs consistently

2016-07-22 Thread Johannes Schindelin
The vast majority of error messages in Git's source code which report a bug use the convention to prefix the message with "BUG:". As part of cleaning up merge-recursive to stop die()ing except in case of detected bugs, let's just make the remainder of the bug reports consistent with the de facto r