Re: [PATCH v4 02/14] commit-graph: prepare for commit-graph chains

2019-06-07 Thread Derrick Stolee
On 6/6/2019 5:28 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> +static void load_oid_from_graph(struct commit_graph *g, int pos, struct >> object_id *oid) >> +{ >> +uint32_t lex_index; >> + >> +if (!g) >> +BUG("NULL commit-graph"); >> + >> +wh

Re: [PATCH v4 02/14] commit-graph: prepare for commit-graph chains

2019-06-06 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > +static void load_oid_from_graph(struct commit_graph *g, int pos, struct > object_id *oid) > +{ > + uint32_t lex_index; > + > + if (!g) > + BUG("NULL commit-graph"); > + > + while (pos < g->num_commits_in_base) > + g

Re: [PATCH v4 02/14] commit-graph: prepare for commit-graph chains

2019-06-06 Thread Philip Oakley
spelling nit in the commit message.. On 06/06/2019 15:15, Derrick Stolee via GitGitGadget wrote: * graph position: the posiiton within the concatenated order s/posiiton/position/ -- Philip

[PATCH v4 02/14] commit-graph: prepare for commit-graph chains

2019-06-06 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee To prepare for a chain of commit-graph files, augment the commit_graph struct to point to a base commit_graph. As we load commits from the graph, we may actually want to read from a base file according to the graph position. The "graph position" of a commit is given by conca