Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-28 Thread Duy Nguyen
On Mon, Jul 27, 2015 at 5:18 PM, Duy Nguyen wrote: > On Mon, Jul 27, 2015 at 2:39 PM, Jacob Keller wrote: >> On Sun, Jul 26, 2015 at 5:39 PM, Duy Nguyen wrote: >>> On Sun, Jul 26, 2015 at 11:08 AM, Eric Sunshine >>> wrote: You can generate an interdiff with "git diff branchname-v4 br

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-27 Thread Matthieu Moy
Karthik Nayak writes: > I've been working on the same branch, and that's why I didn't really > provide interdiff's, You can keep working on the same branch and tag versions you send to the list. "This state is what I sent to the list as vX" is something that does not change in time hence a tag a

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-27 Thread Duy Nguyen
On Mon, Jul 27, 2015 at 2:39 PM, Jacob Keller wrote: > On Sun, Jul 26, 2015 at 5:39 PM, Duy Nguyen wrote: >> On Sun, Jul 26, 2015 at 11:08 AM, Eric Sunshine >> wrote: >>> You can generate an interdiff with "git diff branchname-v4 >>> branchname-v5", for instance. >> >> Off topic. But what stops

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-27 Thread Jacob Keller
On Sun, Jul 26, 2015 at 5:39 PM, Duy Nguyen wrote: > On Sun, Jul 26, 2015 at 11:08 AM, Eric Sunshine > wrote: >> You can generate an interdiff with "git diff branchname-v4 >> branchname-v5", for instance. > > Off topic. But what stops me from doing this often is it creates a big > mess in "git t

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-26 Thread Duy Nguyen
On Sun, Jul 26, 2015 at 11:08 AM, Eric Sunshine wrote: > You can generate an interdiff with "git diff branchname-v4 > branchname-v5", for instance. Off topic. But what stops me from doing this often is it creates a big mess in "git tag -l". Do we have an option to hide away some "insignificant:"

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-25 Thread Karthik Nayak
On Sun, Jul 26, 2015 at 11:28 AM, Eric Sunshine wrote: > On Sun, Jul 26, 2015 at 12:36 AM, Karthik Nayak wrote: >> On Sun, Jul 26, 2015 at 9:38 AM, Eric Sunshine >> wrote: >>> Also, it is helpful to reviewers if you include an interdiff at the >>> bottom of your cover letter showing the changes

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-25 Thread Eric Sunshine
On Sun, Jul 26, 2015 at 12:36 AM, Karthik Nayak wrote: > On Sun, Jul 26, 2015 at 9:38 AM, Eric Sunshine > wrote: >> Also, it is helpful to reviewers if you include an interdiff at the >> bottom of your cover letter showing the changes from one version to >> another. You can generate an interdiff

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-25 Thread Karthik Nayak
On Sun, Jul 26, 2015 at 9:38 AM, Eric Sunshine wrote: > On Fri, Jul 24, 2015 at 3:04 PM, Karthik Nayak wrote: >> Add a new atom "align" and support %(align:X) where X is a number. >> This will align the preceeding atom value to the left followed by > > Do you mean "succeeding" or "following" or "

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-25 Thread Eric Sunshine
On Fri, Jul 24, 2015 at 3:04 PM, Karthik Nayak wrote: > Add a new atom "align" and support %(align:X) where X is a number. > This will align the preceeding atom value to the left followed by Do you mean "succeeding" or "following" or "next" (or something) rather than "preceding"? > spaces for a

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-24 Thread Karthik Nayak
On Sat, Jul 25, 2015 at 4:30 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Karthik Nayak writes: >> >>> -if (!ref->value) { >>> -populate_value(ref); >>> +/* >>> + * If the atom is a pseudo_atom then we re-populate the value >>> + * into the ref_formatting_s

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-24 Thread Junio C Hamano
Junio C Hamano writes: > Karthik Nayak writes: > >> -if (!ref->value) { >> -populate_value(ref); >> +/* >> + * If the atom is a pseudo_atom then we re-populate the value >> + * into the ref_formatting_state stucture. >> + */ >> +if (!ref->value || ref->value[a

Re: [PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-24 Thread Junio C Hamano
Karthik Nayak writes: > - if (!ref->value) { > - populate_value(ref); > + /* > + * If the atom is a pseudo_atom then we re-populate the value > + * into the ref_formatting_state stucture. > + */ > + if (!ref->value || ref->value[atom].pseudo_atom) { > +

[PATCH v4 01/10] ref-filter: add option to align atoms to the left

2015-07-24 Thread Karthik Nayak
From: Karthik Nayak Add a new atom "align" and support %(align:X) where X is a number. This will align the preceeding atom value to the left followed by spaces for a total length of X characters. If X is less than the item size, the entire atom value is printed. Helped-by: Duy Nguyen Helped-by: