Re: [PATCH v4 01/10] Prepare log/log-tree to reuse the diffopt.close_file attribute

2016-06-25 Thread Johannes Schindelin
Hi Junio, On Fri, 24 Jun 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > diff --git a/builtin/log.c b/builtin/log.c > > index 099f4f7..27bc88d 100644 > > --- a/builtin/log.c > > +++ b/builtin/log.c > > @@ -243,9 +243,10 @@ static struct itimerval early_output_timer; > > > > s

Re: [PATCH v4 01/10] Prepare log/log-tree to reuse the diffopt.close_file attribute

2016-06-24 Thread Junio C Hamano
Johannes Schindelin writes: > We are about to teach the log-tree machinery to reuse the diffopt.file > field to output to a file stream other than stdout, in line with the > diff machinery already writing to diffopt.file. > > However, we might want to write something after the diff in > log_tree_

[PATCH v4 01/10] Prepare log/log-tree to reuse the diffopt.close_file attribute

2016-06-22 Thread Johannes Schindelin
We are about to teach the log-tree machinery to reuse the diffopt.file field to output to a file stream other than stdout, in line with the diff machinery already writing to diffopt.file. However, we might want to write something after the diff in log_tree_commit() (e.g. with the --show-linear-bre