Re: [PATCH v4 00/16] pathspec cleanup

2017-01-04 Thread Brandon Williams
On 01/04, Brandon Williams wrote: > On 01/04, Duy Nguyen wrote: > > On Wed, Jan 4, 2017 at 1:42 AM, Brandon Williams wrote: > > > diff --git a/dir.c b/dir.c > > > index 15f7c9993..e8ddd7f8a 100644 > > > --- a/dir.c > > > +++ b/dir.c > > > @@ -1353,6 +1353,15 @@ static int simplify_away(const char

Re: [PATCH v4 00/16] pathspec cleanup

2017-01-04 Thread Brandon Williams
On 01/04, Duy Nguyen wrote: > On Wed, Jan 4, 2017 at 1:42 AM, Brandon Williams wrote: > > diff --git a/dir.c b/dir.c > > index 15f7c9993..e8ddd7f8a 100644 > > --- a/dir.c > > +++ b/dir.c > > @@ -1353,6 +1353,15 @@ static int simplify_away(const char *path, int > > pathlen, > > { > > int

Re: [PATCH v4 00/16] pathspec cleanup

2017-01-04 Thread Duy Nguyen
On Wed, Jan 4, 2017 at 1:42 AM, Brandon Williams wrote: > diff --git a/dir.c b/dir.c > index 15f7c9993..e8ddd7f8a 100644 > --- a/dir.c > +++ b/dir.c > @@ -1353,6 +1353,15 @@ static int simplify_away(const char *path, int pathlen, > { > int i; > > + if (pathspec) > + gu

[PATCH v4 00/16] pathspec cleanup

2017-01-03 Thread Brandon Williams
v4 addresses a few comments from Duy. * [2/16] push the guard pathspec macro into simplify_away() and exclude_matches_pathsepc(). * [6/16] when freeing a pathspec struct, set pathsepc->nr = 0. * [8/16] tweak the die message when using unsupported magic to be more human readable. Brandon Willia