Re: [PATCH v4] upload-pack.c: use of parse-options API

2016-05-30 Thread Antoine Queru
Hello Eric, Thank you for answer. Your remarks have been added in the next version. > > + OPT_BOOL(0, "strict", &strict, > > +N_("do not try /.git/ if is > > no Git directory")), > > Use of OPT_BOOL introduces a --no-strict option which didn't exist > before.

Re: [PATCH v4] upload-pack.c: use of parse-options API

2016-05-27 Thread Eric Sunshine
On Fri, May 27, 2016 at 10:16 AM, Antoine Queru wrote: > upload-pack.c: use of parse-options API Matthieu already mentioned that this should use imperative mood: upload-pack: use parse-options API > Option parsing now uses the parser API instead of a local parser. > Code is now more compact

Re: [PATCH v4] upload-pack.c: use of parse-options API

2016-05-27 Thread Matthieu Moy
> Subject: [PATCH v4] upload-pack.c: use of parse-options API I'd drop the "of" and say just "use parse-options API" Antoine Queru writes: > Description for --stateless-rpc and --advertise-refs come from > the commit 42526b4 (Add stateless RPC o

[PATCH v4] upload-pack.c: use of parse-options API

2016-05-27 Thread Antoine Queru
Option parsing now uses the parser API instead of a local parser. Code is now more compact. Description for --stateless-rpc and --advertise-refs come from the commit 42526b4 (Add stateless RPC options to upload-pack, receive-pack, 2009-10-30). Signed-off-by: Antoine Queru Signed-off-by: Matthieu