Re: [PATCH v4] send-email: extract email-parsing code into a subroutine

2017-12-07 Thread Ævar Arnfjörð Bjarmason
On Thu, Dec 07 2017, Matthieu Moy jotted: > Not terribly important, but your patch has trailing newlines. "git diff > --staged --check" to see them. More below. > > PAYRE NATHAN p1508475 writes: > >> the part of code which parses the header a last time to prepare the >> email and send it. > > Th

Re: [PATCH v4] send-email: extract email-parsing code into a subroutine

2017-12-07 Thread Matthieu Moy
Not terribly important, but your patch has trailing newlines. "git diff --staged --check" to see them. More below. PAYRE NATHAN p1508475 writes: > the part of code which parses the header a last time to prepare the > email and send it. The important point is not that it's the last time the code

[PATCH v4] send-email: extract email-parsing code into a subroutine

2017-12-07 Thread Nathan Payre
The existing code mixes parsing of email header with regular expression and actual code. Extract the parsing code into a new subroutine "parse_header_line()". This improves the code readability and make parse_header_line reusable in other place. "parsed_header_line()" and "filter_body()" could be