Re: [PATCH v4] log: add log.follow config option

2015-07-10 Thread Junio C Hamano
David Turner writes: > On Thu, 2015-07-09 at 10:58 -0700, Junio C Hamano wrote: >> David Turner writes: >> >> > On Thu, 2015-07-09 at 10:23 -0700, Junio C Hamano wrote: >> > >> >> If I were David and sending this v4 patch, it would have looked like >> >> this. >> >> >> >> -- >8 -- >> >> >> >>

Re: [PATCH v4] log: add log.follow config option

2015-07-10 Thread David Turner
On Thu, 2015-07-09 at 10:58 -0700, Junio C Hamano wrote: > David Turner writes: > > > On Thu, 2015-07-09 at 10:23 -0700, Junio C Hamano wrote: > > > >> If I were David and sending this v4 patch, it would have looked like > >> this. > >> > >> -- >8 -- > >> > >> From: David Turner > >> Date: Tue

Re: [PATCH v4] log: add log.follow config option

2015-07-09 Thread Junio C Hamano
David Turner writes: > On Thu, 2015-07-09 at 10:23 -0700, Junio C Hamano wrote: > >> If I were David and sending this v4 patch, it would have looked like >> this. >> >> -- >8 -- >> >> From: David Turner >> Date: Tue, 7 Jul 2015 21:29:34 -0400 >> Subject: [PATCH v4] log: add "log.follow" config

Re: [PATCH v4] log: add log.follow config option

2015-07-09 Thread David Turner
On Thu, 2015-07-09 at 10:23 -0700, Junio C Hamano wrote: > If I were David and sending this v4 patch, it would have looked like > this. > > -- >8 -- > > From: David Turner > Date: Tue, 7 Jul 2015 21:29:34 -0400 > Subject: [PATCH v4] log: add "log.follow" configuration variable > > People who wo

Re: [PATCH v4] log: add log.follow config option

2015-07-09 Thread Junio C Hamano
Matthieu Moy writes: > David Turner writes: > >> This version uses tweak, and also includes Matthieu Moy's suggested >> whitespace fix. > > This comment should come below the --- after the commit message (right > before the diffstat). Otherwise, Junio will get this as the commit > message when a

Re: [PATCH v4] log: add log.follow config option

2015-07-09 Thread Matthieu Moy
David Turner writes: > This version uses tweak, and also includes Matthieu Moy's suggested > whitespace fix. This comment should come below the --- after the commit message (right before the diffstat). Otherwise, Junio will get this as the commit message when applying, and your actual commit mes

[PATCH v4] log: add log.follow config option

2015-07-08 Thread David Turner
This version uses tweak, and also includes Matthieu Moy's suggested whitespace fix. --- Many users prefer to always use --follow with logs. Rather than aliasing the command, an option might be more convenient for some. Junio C Hamano suggested using the tweak functionality for this, which is mu