Re: [PATCH v4] git-gui: add hotkey to toggle "Amend Last Commit"

2019-09-14 Thread Birger Skogeng Pedersen
Thanks, I really appreciate you taking time to explain it thoroughly. On Sat, Sep 14, 2019 at 12:11 AM Pratyush Yadav wrote: > So while my advice above was to work on top of "master", that does not > apply in this case since your patch is dependent on someone's patch > which isn't in master yet.

Re: [PATCH v4] git-gui: add hotkey to toggle "Amend Last Commit"

2019-09-13 Thread Pratyush Yadav
+Cc Junio so you know what development model I'm using, and comment with your thoughts (if you want to). On 13/09/19 11:32PM, Birger Skogeng Pedersen wrote: > On Fri, Sep 13, 2019 at 4:37 PM Pratyush Yadav wrote: > > Hi Birger, > > > > I'm afraid you are working on an older version of this pat

Re: [PATCH v4] git-gui: add hotkey to toggle "Amend Last Commit"

2019-09-13 Thread Birger Skogeng Pedersen
On Fri, Sep 13, 2019 at 4:37 PM Pratyush Yadav wrote: > Hi Birger, > > I'm afraid you are working on an older version of this patch. You should > be re-rolling [0], which works well with Bert's "amend check button" > change. > > [0] > https://public-inbox.org/git/b82a00441ff1a6a9cea3fd235c1c33729

[PATCH v4] git-gui: add hotkey to toggle "Amend Last Commit"

2019-09-13 Thread Birger Skogeng Pedersen
Selecting whether to "Amend Last Commit" or not does not have a hotkey. With this patch, the user may toggle between the two options with CTRL/CMD+e. Signed-off-by: Birger Skogeng Pedersen Rebased-by: Bert Wesarg --- git-gui.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/git-g