From: "Pranit Bauva"
On Fri, Mar 11, 2016 at 4:31 AM, Eric Sunshine
wrote:
Add commit.verbose configuration variable as a convenience
for those who always prefer --verbose.
or something.
Sure!
As a convenience to reviewers, please use this area below the "---"
line to provide li
On 11 March 2016 at 05:44, Eric Sunshine wrote:
> On Fri, Mar 11, 2016 at 05:45:27AM +0530, Pranit Bauva wrote:
>> Actually I am sending the patches with submitGit herokuapp because my
>> institute proxy does not allow IMAP/POP3 connections.
Really glad to hear this is helping you Pranit - I hadn
On Fri, Mar 11, 2016 at 11:14 AM, Eric Sunshine wrote:
> It's a bit tricky if you're not used to it, but check-for-diff
> actually does what you want, and does so in a more direct way. While
> it's true that it's not an "editor" per se, it does get access to the
> entire block of text that would
[+cc:Roberto Tyley]
On Fri, Mar 11, 2016 at 05:45:27AM +0530, Pranit Bauva wrote:
> On Fri, Mar 11, 2016 at 4:31 AM, Eric Sunshine
> wrote:
> > As a convenience to reviewers, please use this area below the "---"
> > line to provide links and explain what changed since the previous
> > round rath
On Fri, Mar 11, 2016 at 4:31 AM, Eric Sunshine wrote:
> Add commit.verbose configuration variable as a convenience
> for those who always prefer --verbose.
>
> or something.
Sure!
> As a convenience to reviewers, please use this area below the "---"
> line to provide links and explain w
> + if (!strcmp(k, "commit.verbose")){
> v3 did this line correctly but you somehow lost the SP between
> "){". What happened?
I will include the SP between )) and { .
> Don't you need a test that status is not broken when the variable is
> set?
I will include the test for status too. But
On Thu, Mar 10, 2016 at 5:12 PM, Pranit Bauva wrote:
> Since many people always run the command with this option, it would be
> preferrable to specify it in the configuration file instead of passing
> the option with `git commit` again and again.
Perhaps drop the unsubstantiated "many people alwa
Pranit Bauva writes:
> + if (!strcmp(k, "commit.verbose")){
v3 did this line correctly but you somehow lost the SP between
"){". What happened?
> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> index 2ddf28c..4e123a5 100755
> --- a/t/t7507-commit-verbose.sh
> +++ b/t/t
Older versions of this patch can be found at :-
[v3] : http://thread.gmane.org/gmane.comp.version-control.git/288634
[v2] : http://thread.gmane.org/gmane.comp.version-control.git/288569
[v1] : http://thread.gmane.org/gmane.comp.version-control.git/287540
The changes with respect to last version
Since many people always run the command with this option, it would be
preferrable to specify it in the configuration file instead of passing
the option with `git commit` again and again.
Signed-off-by: Pranit Bauva
---
Documentation/config.txt | 4
Documentation/git-commit.txt | 3 ++
10 matches
Mail list logo
