Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-02-09 Thread Philip Oakley
Hi, On 24/01/2019 01:12, Jonathan Nieder wrote: Hi, Junio C Hamano wrote: Thomas Gummerer writes: Jonathan Nieder wrote: Is this analogous to "git add --ignore-removal"? If so, can we just call it --ignore-removal? Yes, it seems like they are very similar. Hmm, I am not sure if the word

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-25 Thread Duy Nguyen
On Fri, Jan 25, 2019 at 9:26 AM Jonathan Nieder wrote: > > Junio C Hamano wrote: > > Jonathan Nieder writes: > > >> I find --ignore-removal fairly easy to understand, and I had no idea > >> what --overlay would mean. > >> > >> I realize this is just one user's experience. > > > > Exactly. My imp

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-24 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >> I find --ignore-removal fairly easy to understand, and I had no idea >> what --overlay would mean. >> >> I realize this is just one user's experience. > > Exactly. My impression was the exact opposite from yours. > > The phrase "removal" in the

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-24 Thread Junio C Hamano
Jonathan Nieder writes: > I find --ignore-removal fairly easy to understand, and I had no idea > what --overlay would mean. > > I realize this is just one user's experience. Exactly. My impression was the exact opposite from yours. The phrase "removal" in the context of checkout does not click

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-24 Thread Thomas Gummerer
On 01/23, Jonathan Nieder wrote: > Thomas Gummerer wrote: > > On 01/22, Jonathan Nieder wrote: > > > As checkout is a porcelain command, I had hoped it would be okay to > > also have this as a configuration option, for the time before > > 'checkout-paths' exists and while I'm getting used to actua

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-24 Thread Thomas Gummerer
On 01/23, Jonathan Nieder wrote: > Hi, > > Junio C Hamano wrote: > > Thomas Gummerer writes: > >> Jonathan Nieder wrote: > > >>> Is this analogous to "git add --ignore-removal"? If so, can we just > >>> call it --ignore-removal? > >> > >> Yes, it seems like they are very similar. > > > > Hmm, I

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Jonathan Nieder
Hi, Junio C Hamano wrote: > Thomas Gummerer writes: >> Jonathan Nieder wrote: >>> Is this analogous to "git add --ignore-removal"? If so, can we just >>> call it --ignore-removal? >> >> Yes, it seems like they are very similar. > > Hmm, I am not sure if the word "removal" makes sense in the con

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Junio C Hamano
Thomas Gummerer writes: >> I had no idea what --overlay would mean and am still not clear on it. >> Is this analogous to "git add --ignore-removal"? If so, can we just >> call it --ignore-removal? > > Yes, it seems like they are very similar. Hmm, I am not sure if the word "removal" makes sense

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Jonathan Nieder
Thomas Gummerer wrote: > On 01/22, Jonathan Nieder wrote: >> I had no idea what --overlay would mean and am still not clear on it. >> Is this analogous to "git add --ignore-removal"? If so, can we just >> call it --ignore-removal? > > Yes, it seems like they are very similar. I'm happy to rename

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Thomas Gummerer
On 01/22, Jonathan Nieder wrote: > Hi, > > Thomas Gummerer wrote: > > > Currently 'git checkout' is defined as an overlay operation, which > > means that if in 'git checkout -- []' we have an > > entry in the index that matches , but that doesn't exist in > > , that entry will not be removed fro

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-23 Thread Junio C Hamano
Jonathan Nieder writes: > I'm nervous about the config with no associated warning or plan for > phasing it out. This was discussed long ago (in my panda-brain timescale) but my recollection is to keep "checkout" default to the traditional "overlay what was read from the tree on top of the curren

Re: [PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-22 Thread Jonathan Nieder
Hi, Thomas Gummerer wrote: > Currently 'git checkout' is defined as an overlay operation, which > means that if in 'git checkout -- []' we have an > entry in the index that matches , but that doesn't exist in > , that entry will not be removed from the index or the > working tree. > > Introduce

[PATCH v3 7/8] checkout: introduce --{,no-}overlay option

2019-01-08 Thread Thomas Gummerer
Currently 'git checkout' is defined as an overlay operation, which means that if in 'git checkout -- []' we have an entry in the index that matches , but that doesn't exist in , that entry will not be removed from the index or the working tree. Introduce a new --{,no-}overlay option, which allows