Re: [PATCH v3 5/8] tests: make GIT_TEST_GETTEXT_POISON a boolean

2019-06-24 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > diff --git a/config.c b/config.c > index 374cb33005..b985d60fa4 100644 > --- a/config.c > +++ b/config.c > @@ -956,6 +956,15 @@ static void die_bad_number(const char *name, const char > *value) > if (!value) > value = ""; > > + if (!st

[PATCH v3 5/8] tests: make GIT_TEST_GETTEXT_POISON a boolean

2019-06-21 Thread Ævar Arnfjörð Bjarmason
Change the GIT_TEST_GETTEXT_POISON variable from being "non-empty?" to being a more standard boolean variable. Since it needed to be checked in both C code and shellscript (via test -n) it was one of the remaining shellscript-like variables. Now that we have "env--helper" we can change that. Ther