Re: [PATCH v3 5/7] completion: get rid of compgen

2013-04-12 Thread Junio C Hamano
Felipe Contreras writes: > Here are some numbers filtering N amount of words: Nice table. "N amount of words" sounded somewhat funny to me, but I am not a native. > ... > == 1000 == > original: 0.012s > new: 0.011s > == 1 == > original: 0.056s > new: 0.066s > == 10 == >

Re: [PATCH v3 5/7] completion: get rid of compgen

2013-04-10 Thread John Keeping
On Wed, Apr 10, 2013 at 06:07:33AM -0500, Felipe Contreras wrote: > On Wed, Apr 10, 2013 at 5:10 AM, Eric Sunshine > wrote: > > s/specially/especially/ > > http://www.merriam-webster.com/dictionary/specially But see also: http://www.merriam-webster.com/dictionary/especially which notes "i

Re: [PATCH v3 5/7] completion: get rid of compgen

2013-04-10 Thread Felipe Contreras
On Wed, Apr 10, 2013 at 5:10 AM, Eric Sunshine wrote: > s/specially/especially/ http://www.merriam-webster.com/dictionary/specially -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3 5/7] completion: get rid of compgen

2013-04-10 Thread Eric Sunshine
On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras wrote: > The functionality we use from compgen is not much, we can do the same > manually, with drastical improvements in speed, specially when dealing s/drastical/drastic/ s/specially/especially/ > with only a few words. > > This patch also has

[PATCH v3 5/7] completion: get rid of compgen

2013-04-09 Thread Felipe Contreras
The functionality we use from compgen is not much, we can do the same manually, with drastical improvements in speed, specially when dealing with only a few words. This patch also has the sideffect that brekage reported by Jeroen Meijer and SZEDER Gábor gets fixed because we no longer expand the r