Re: [PATCH v3 4/7] notes copy --stdin: split lines with string_list_split()

2016-02-28 Thread Eric Sunshine
On Sun, Feb 28, 2016 at 2:47 AM, Moritz Neeb wrote: > On 02/28/2016 07:56 AM, Eric Sunshine wrote: >> On Sun, Feb 28, 2016 at 12:13 AM, Moritz Neeb wrote: >>> The strbuf is now rtrimmed before splitting. This is still required >>> to remove potential CRs. In the next step this will then be done >

Re: [PATCH v3 4/7] notes copy --stdin: split lines with string_list_split()

2016-02-27 Thread Moritz Neeb
On 02/28/2016 07:56 AM, Eric Sunshine wrote: > On Sun, Feb 28, 2016 at 12:13 AM, Moritz Neeb wrote: >> This patch changes, how the lines are split, when reading them from >> stdin to copy the notes. The advantage of string_list_split() over >> strbuf_split() is that it removes the terminator, maki

Re: [PATCH v3 4/7] notes copy --stdin: split lines with string_list_split()

2016-02-27 Thread Eric Sunshine
On Sun, Feb 28, 2016 at 12:13 AM, Moritz Neeb wrote: > This patch changes, how the lines are split, when reading them from > stdin to copy the notes. The advantage of string_list_split() over > strbuf_split() is that it removes the terminator, making trimming > of the left part unneccesary. Here'

[PATCH v3 4/7] notes copy --stdin: split lines with string_list_split()

2016-02-27 Thread Moritz Neeb
This patch changes, how the lines are split, when reading them from stdin to copy the notes. The advantage of string_list_split() over strbuf_split() is that it removes the terminator, making trimming of the left part unneccesary. The strbuf is now rtrimmed before splitting. This is still required