Re: [PATCH v3 4/4] tests: define GIT_TEST_SIDEBAND_ALL

2019-02-12 Thread Jeff King
On Tue, Jan 29, 2019 at 03:27:32PM -0800, Jonathan Nieder wrote: > Jonathan Tan wrote: > > > --- a/t/lib-httpd/apache.conf > > +++ b/t/lib-httpd/apache.conf > > @@ -78,6 +78,7 @@ PassEnv GNUPGHOME > > PassEnv ASAN_OPTIONS > > PassEnv GIT_TRACE > > PassEnv GIT_CONFIG_NOSYSTEM > > +PassEnv GIT_T

Re: [PATCH v3 4/4] tests: define GIT_TEST_SIDEBAND_ALL

2019-01-29 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > --- a/t/lib-httpd/apache.conf > +++ b/t/lib-httpd/apache.conf > @@ -78,6 +78,7 @@ PassEnv GNUPGHOME > PassEnv ASAN_OPTIONS > PassEnv GIT_TRACE > PassEnv GIT_CONFIG_NOSYSTEM > +PassEnv GIT_TEST_SIDEBAND_ALL This is producing [env:warn] [pid 248632] AH01506: PassEnv

[PATCH v3 4/4] tests: define GIT_TEST_SIDEBAND_ALL

2019-01-16 Thread Jonathan Tan
Define a GIT_TEST_SIDEBAND_ALL environment variable meant to be used from tests. When set to true, this overrides uploadpack.allowsidebandall to true, allowing the entire test suite to be run as if this configuration is in place for all repositories. As of this patch, all tests pass whether GIT_TE