Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

2015-06-08 Thread Junio C Hamano
Michael Haggerty writes: > Thanks for all the comments. Taking them into consideration, I suggest > changing the last commit message to > ... > Since the only comments were about this one commit message,... Yeah, this round looked good otherwise. Will amend in-place. Thanks. -- To unsubscribe

Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

2015-06-08 Thread Michael Haggerty
On 06/03/2015 11:20 PM, Junio C Hamano wrote: > Jeff King writes: > >> On Wed, Jun 03, 2015 at 11:51:43AM -0700, Junio C Hamano wrote: >> >>> Jeff King writes: >>> On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote: > NULL_SHA1 is used to indicate of "invalid SHA-1" t

Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

2015-06-03 Thread Junio C Hamano
Jeff King writes: > On Wed, Jun 03, 2015 at 11:51:43AM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >> > On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote: >> > >> >> NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code >> > >> > s/of/an/ ? >> >> Also p

Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

2015-06-03 Thread Jeff King
On Wed, Jun 03, 2015 at 11:51:43AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote: > > > >> NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code > > > > s/of/an/ ? > > Also possibly s/invalid SHA-1/invalid

Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

2015-06-03 Thread Junio C Hamano
Jeff King writes: > On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote: > >> NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code > > s/of/an/ ? Also possibly s/invalid SHA-1/invalid ref/? >> (and the code of other git implementations), so it is vastly more >> like

Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

2015-06-03 Thread Jeff King
On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote: > NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code s/of/an/ ? > (and the code of other git implementations), so it is vastly more > likely that a reference was set to this value due to a software bug > than tha

[PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken

2015-06-03 Thread Michael Haggerty
NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code (and the code of other git implementations), so it is vastly more likely that a reference was set to this value due to a software bug than that NULL_SHA1 is the legitimate SHA-1 of an actual object. Therefore, if a loose reference