Re: [PATCH v3 3/7] t3422: new testcases for checking when incompatible options passed

2018-06-21 Thread Eric Sunshine
On Thu, Jun 21, 2018 at 4:05 PM Junio C Hamano wrote: > Elijah Newren writes: > > + # This is indented with HT SP HT. > > + echo " foo();" >>foo && > > I often wonder, whenever I see a need for a comment like this, if > saying the same thing in code to make it visible is cleaner

Re: [PATCH v3 3/7] t3422: new testcases for checking when incompatible options passed

2018-06-21 Thread Elijah Newren
On Thu, Jun 21, 2018 at 1:04 PM, Junio C Hamano wrote: > Elijah Newren writes: > >> + git checkout B && >> + # This is indented with HT SP HT. >> + echo " foo();" >>foo && > > I often wonder, whenever I see a need for a comment like this, if > saying the same thing in code to

Re: [PATCH v3 3/7] t3422: new testcases for checking when incompatible options passed

2018-06-21 Thread Junio C Hamano
Elijah Newren writes: > + git checkout B && > + # This is indented with HT SP HT. > + echo " foo();" >>foo && I often wonder, whenever I see a need for a comment like this, if saying the same thing in code to make it visible is cleaner and less error prone way to do so, i.e.

[PATCH v3 3/7] t3422: new testcases for checking when incompatible options passed

2018-06-21 Thread Elijah Newren
git rebase is split into three types: am, merge, and interactive. Various options imply different types, and which mode we are using determine which sub-script (git-rebase--$type) is executed to finish the work. Not all options work with all types, so add tests for combinations where we expect to