Re: [PATCH v3 3/7] clean: read user input with strbuf_getline()

2016-02-27 Thread Moritz Neeb
On 02/28/2016 07:36 AM, Eric Sunshine wrote: > On Sun, Feb 28, 2016 at 12:13 AM, Moritz Neeb wrote: >> The inputs that are read are all answers that are given by the user >> when interacting with git on the commandline. As these answers are >> not supposed to contain a meaningful CR it is safe to

Re: [PATCH v3 3/7] clean: read user input with strbuf_getline()

2016-02-27 Thread Eric Sunshine
On Sun, Feb 28, 2016 at 12:13 AM, Moritz Neeb wrote: > The inputs that are read are all answers that are given by the user > when interacting with git on the commandline. As these answers are > not supposed to contain a meaningful CR it is safe to > replace strbuf_getline_lf() can be replaced by s

[PATCH v3 3/7] clean: read user input with strbuf_getline()

2016-02-27 Thread Moritz Neeb
The inputs that are read are all answers that are given by the user when interacting with git on the commandline. As these answers are not supposed to contain a meaningful CR it is safe to replace strbuf_getline_lf() can be replaced by strbuf_getline(). In the subsequent codepath, the input is tri