Re: [PATCH v3 3/4] t7800: modernize tests

2013-03-22 Thread John Keeping
On Fri, Mar 22, 2013 at 12:14:27PM +0100, Johannes Sixt wrote: > Am 3/22/2013 11:00, schrieb John Keeping: > > On Fri, Mar 22, 2013 at 08:13:46AM +0100, Johannes Sixt wrote: > >> Am 3/21/2013 8:41, schrieb Johannes Sixt: > >>> Am 3/20/2013 23:59, schrieb David Aguilar: > I started digging in a

Re: [PATCH v3 3/4] t7800: modernize tests

2013-03-22 Thread Johannes Sixt
Am 3/22/2013 11:00, schrieb John Keeping: > On Fri, Mar 22, 2013 at 08:13:46AM +0100, Johannes Sixt wrote: >> Am 3/21/2013 8:41, schrieb Johannes Sixt: >>> Am 3/20/2013 23:59, schrieb David Aguilar: I started digging in and the @worktree_files (aka @worktree above) is populated from the o

Re: [PATCH v3 3/4] t7800: modernize tests

2013-03-22 Thread John Keeping
On Fri, Mar 22, 2013 at 08:13:46AM +0100, Johannes Sixt wrote: > Am 3/21/2013 8:41, schrieb Johannes Sixt: > > Am 3/20/2013 23:59, schrieb David Aguilar: > >> I started digging in and the @worktree_files (aka @worktree above) > >> is populated from the output of "git diff --raw ...". > >> > >> Seei

Re: [PATCH v3 3/4] t7800: modernize tests

2013-03-22 Thread Johannes Sixt
Am 3/21/2013 8:41, schrieb Johannes Sixt: > Am 3/20/2013 23:59, schrieb David Aguilar: >> I started digging in and the @worktree_files (aka @worktree above) >> is populated from the output of "git diff --raw ...". >> >> Seeing the "output" filename in "diff --raw" implies that one of the >> tests a

Re: [PATCH v3 3/4] t7800: modernize tests

2013-03-21 Thread Johannes Sixt
Am 3/20/2013 23:59, schrieb David Aguilar: > I started digging in and the @worktree_files (aka @worktree above) > is populated from the output of "git diff --raw ...". > > Seeing the "output" filename in "diff --raw" implies that one of the > tests added "output" to the index somehow. I do not se

Re: [PATCH v3 3/4] t7800: modernize tests

2013-03-20 Thread David Aguilar
On Wed, Mar 20, 2013 at 2:48 AM, Johannes Sixt wrote: > Am 2/21/2013 5:03, schrieb David Aguilar: >> test_expect_success PERL 'difftool -d' ' >> - diff=$(git difftool -d --extcmd ls branch) && >> - echo "$diff" | stdin_contains sub && >> - echo "$diff" | stdin_contains file >> + g

Re: [PATCH v3 3/4] t7800: modernize tests

2013-03-20 Thread Johannes Sixt
Am 2/21/2013 5:03, schrieb David Aguilar: > test_expect_success PERL 'difftool -d' ' > - diff=$(git difftool -d --extcmd ls branch) && > - echo "$diff" | stdin_contains sub && > - echo "$diff" | stdin_contains file > + git difftool -d --extcmd ls branch >output && > + stdin_con

[PATCH v3 3/4] t7800: modernize tests

2013-02-20 Thread David Aguilar
Eliminate a lot of redundant work by using test_config(). Catch more return codes by more use of temporary files and test_cmp. The original tests relied upon restore_test_defaults() from the previous test to provide the next test with a sane environment. Make the tests do their own setup so that