Re: [PATCH v3 3/4] close the index lock when not writing the new index

2017-05-28 Thread Junio C Hamano
Joel Teichroeb writes: > Signed-off-by: Joel Teichroeb > --- The title says what the patch does; it does not explain why it is a good change. Lockfiles will be closed automatically when we exit anyway, so one can argue that the current code is good. If you are planning to add more code to the

Re: [PATCH v3 3/4] close the index lock when not writing the new index

2017-05-28 Thread Ævar Arnfjörð Bjarmason
On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > Signed-off-by: Joel Teichroeb > --- > builtin/add.c | 3 ++- > builtin/mv.c | 8 +--- > builtin/rm.c | 3 ++- > merge-recursive.c | 8 +--- > 4 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/builtin/

[PATCH v3 3/4] close the index lock when not writing the new index

2017-05-28 Thread Joel Teichroeb
Signed-off-by: Joel Teichroeb --- builtin/add.c | 3 ++- builtin/mv.c | 8 +--- builtin/rm.c | 3 ++- merge-recursive.c | 8 +--- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/builtin/add.c b/builtin/add.c index 9f53f020d0..6b04eb2c71 100644 --- a/builtin/a