Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-10 Thread Junio C Hamano
Matthieu Moy writes: > Please, don't top-post. Quote the part of the message you're replying > to, and reply below. > > Benoît Person writes: > >> Well, I think next step would be to replace all those calls with >> Git.pm `command`, `command_oneline` and `config``which take an array >> of argume

Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-10 Thread Matthieu Moy
Please, don't top-post. Quote the part of the message you're replying to, and reply below. Benoît Person writes: > Well, I think next step would be to replace all those calls with > Git.pm `command`, `command_oneline` and `config``which take an array > of arguments after the "command". In the pr

Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-10 Thread Benoît Person
Well, I think next step would be to replace all those calls with Git.pm `command`, `command_oneline` and `config``which take an array of arguments after the "command". In the preview tool we use those but I don't know if we will find the time to clean that up too in git-remote-mediawiki :) . Don't

Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-10 Thread Junio C Hamano
Matthieu Moy writes: > Célestin Matte writes: > >> @@ -1285,8 +1285,7 @@ sub get_mw_namespace_id { >> # Look at configuration file, if the record for that namespace >> is >> # already cached. Namespaces are stored in form: >> # "Name_of_namespace:Id_namesp

Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-10 Thread Célestin Matte
Le 10/06/2013 10:37, Matthieu Moy a écrit : > Célestin Matte writes: > >> @@ -1285,8 +1285,7 @@ sub get_mw_namespace_id { >> # Look at configuration file, if the record for that namespace >> is >> # already cached. Namespaces are stored in form: >> # "Name_

Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-10 Thread Célestin Matte
Le 10/06/2013 02:50, Eric Sunshine a écrit : > Given this patch's intention to use ${} within strings, should this be > ${credential{username}}? > > (I don't have a preference, but it's a genuine question since it's not > clear if this was an oversight or intentional.) The answer is simple: I did

Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-10 Thread Matthieu Moy
Célestin Matte writes: > @@ -1285,8 +1285,7 @@ sub get_mw_namespace_id { > # Look at configuration file, if the record for that namespace > is > # already cached. Namespaces are stored in form: > # "Name_of_namespace:Id_namespace", ex.: "File:6". > -

Re: [PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-09 Thread Eric Sunshine
On Sun, Jun 9, 2013 at 6:22 PM, Célestin Matte wrote: > - strings which don't need interpolation are single-quoted for more clarity > and > slight gain of performance > - interpolation is preferred over concatenation in many cases, for more > clarity > - variables are always used with the ${} op

[PATCH v3 22/28] git-remote-mediawiki: Modify strings for a better coding-style

2013-06-09 Thread Célestin Matte
- strings which don't need interpolation are single-quoted for more clarity and slight gain of performance - interpolation is preferred over concatenation in many cases, for more clarity - variables are always used with the ${} operator inside strings - strings including double-quotes are written w