Re: [PATCH v3 2/7] bisect: read bisect paths with strbuf_getline()

2016-02-27 Thread Moritz Neeb
On 02/28/2016 07:33 AM, Eric Sunshine wrote: > On Sun, Feb 28, 2016 at 12:13 AM, Moritz Neeb wrote: >> The file BISECT_NAMES is written by "git rev-parse --sq-quote" via >> sq_quote_argv() when starting a bisection. It can contain pathspecs >> to narrow down the search. When reading it back, it sh

Re: [PATCH v3 2/7] bisect: read bisect paths with strbuf_getline()

2016-02-27 Thread Eric Sunshine
On Sun, Feb 28, 2016 at 12:13 AM, Moritz Neeb wrote: > The file BISECT_NAMES is written by "git rev-parse --sq-quote" via > sq_quote_argv() when starting a bisection. It can contain pathspecs > to narrow down the search. When reading it back, it should be expected that > sq_dequote_to_argv_array()

[PATCH v3 2/7] bisect: read bisect paths with strbuf_getline()

2016-02-27 Thread Moritz Neeb
The file BISECT_NAMES is written by "git rev-parse --sq-quote" via sq_quote_argv() when starting a bisection. It can contain pathspecs to narrow down the search. When reading it back, it should be expected that sq_dequote_to_argv_array() is able to parse this file. In fact, the previous commit ensu