Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-04 Thread Matthieu Moy
Christian Couder writes: > You might also want to check: > > http://www.shellcheck.net/ Indeed, it's also an excellent tool to check for common mistakes in shell scripts (there are many, and shellcheck is good at pointing them out and explaining them). http://www.shellcheck.net/ (Available onl

Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-04 Thread Christian Couder
On Wed, May 4, 2016 at 10:04 AM, Lars Schneider wrote: > > On 03 May 2016, at 17:43, Junio C Hamano wrote: > >> Lars Schneider writes: >> >>> On 02 May 2016, at 22:45, Junio C Hamano wrote: >>> larsxschnei...@gmail.com writes: > +set -e > + > +LINKS=$(grep --recursive --on

Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-04 Thread Junio C Hamano
Lars Schneider writes: > A quick Google search told me that "dash" from Ubuntu seems > to be a good baseline as it aims to support pretty much only POSIX [1]. Yeah that is a good and safe starting point. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message t

Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-04 Thread Eric Wong
Lars Schneider wrote: > OK. I am not that experienced with shell scripting and therefore it > is hard for me to distinguish between the different shell features. > Do you know/can you recommend the most basic shell to test/work > with? A quick Google search told me that "dash" from Ubuntu seems >

Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-04 Thread Lars Schneider
On 03 May 2016, at 17:43, Junio C Hamano wrote: > Lars Schneider writes: > >> On 02 May 2016, at 22:45, Junio C Hamano wrote: >> >>> larsxschnei...@gmail.com writes: >>> +set -e + +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ +'(?<=linkgit:)

Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-03 Thread Junio C Hamano
Lars Schneider writes: > On 02 May 2016, at 22:45, Junio C Hamano wrote: > >> larsxschnei...@gmail.com writes: >> >>> +set -e >>> + >>> +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ >>> +'(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ >>> +| sort -u \ >>> +) >>

Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-03 Thread Lars Schneider
On 02 May 2016, at 22:45, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> +set -e >> + >> +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ >> +'(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ >> +| sort -u \ >> +) >> + >> +for LINK in $LINKS; do >> +

Re: [PATCH v3 2/2] travis-ci: build documentation

2016-05-02 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > +set -e > + > +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ > +'(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ > +| sort -u \ > +) > + > +for LINK in $LINKS; do > +echo "Checking linkgit:$LINK..." > +test -s Documentation

[PATCH v3 2/2] travis-ci: build documentation

2016-05-02 Thread larsxschneider
From: Lars Schneider Build documentation as separate Travis CI job to check for documentation errors. Signed-off-by: Lars Schneider --- .travis.yml | 15 +++ ci/test-documentation.sh | 24 2 files changed, 39 insertions(+) create mode 100755 c