Re: [PATCH v3 2/2] t9813: avoid using pipes

2017-01-04 Thread Pranit Bauva
Hey Luke, On Wed, Jan 4, 2017 at 2:41 PM, Luke Diamand wrote: > On 3 January 2017 at 19:57, Pranit Bauva wrote: >> The exit code of the upstream in a pipe is ignored thus we should avoid >> using it. By writing out the output of the git command to a file, we can >> test the exit codes of both th

Re: [PATCH v3 2/2] t9813: avoid using pipes

2017-01-04 Thread Luke Diamand
On 3 January 2017 at 19:57, Pranit Bauva wrote: > The exit code of the upstream in a pipe is ignored thus we should avoid > using it. By writing out the output of the git command to a file, we can > test the exit codes of both the commands. Do we also need to fix t9814-git-p4-rename.sh ? > > Sig

[PATCH v3 2/2] t9813: avoid using pipes

2017-01-03 Thread Pranit Bauva
The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Pranit Bauva --- t/t9813-git-p4-preserve-users.sh | 8 1 file changed, 4 insertions(+