Re: [PATCH v3 2/2] difftool: implement the functionality in the builtin

2016-11-27 Thread Jakub Narębski
Hello Johannes, On 27 November 2016 at 12:10, Johannes Schindelin wrote: > On Fri, 25 Nov 2016, Jakub Narębski wrote: > > W dniu 24.11.2016 o 21:55, Johannes Schindelin pisze: [...] > > > +static int difftool_config(const char *var, const char *value, void *cb) > > > +{ > > > + if (!strcmp(var

Re: [PATCH v3 2/2] difftool: implement the functionality in the builtin

2016-11-27 Thread Johannes Schindelin
Hi Jakub, On Fri, 25 Nov 2016, Jakub Narębski wrote: > W dniu 24.11.2016 o 21:55, Johannes Schindelin pisze: > > > The current version of the builtin difftool does not, however, make > > full use of the internals but instead chooses to spawn a couple of Git > > processes, still, to make for an e

Re: [PATCH v3 2/2] difftool: implement the functionality in the builtin

2016-11-25 Thread Jakub Narębski
W dniu 24.11.2016 o 21:55, Johannes Schindelin pisze: > The current version of the builtin difftool does not, however, make full > use of the internals but instead chooses to spawn a couple of Git > processes, still, to make for an easier conversion. There remains a lot > of room for improvement,

[PATCH v3 2/2] difftool: implement the functionality in the builtin

2016-11-24 Thread Johannes Schindelin
This patch gives life to the skeleton added in the previous patch. The motivation for converting the difftool is that Perl scripts are not at all native on Windows, and that `git difftool` therefore is pretty slow on that platform, when there is no good reason for it to be slow. In addition, Perl