Re: [PATCH v3 19/19] delete_ref(): use the usual convention for old_sha1

Michael Haggerty writes: > The ref_transaction_update() family of functions use the following > convention for their old_sha1 parameters: > > * old_sha1 == NULL: Don't check the old value at all. > * is_null_sha1(old_sha1): Ensure that the reference didn't exist > before the transaction. > * ot

[PATCH v3 19/19] delete_ref(): use the usual convention for old_sha1

The ref_transaction_update() family of functions use the following convention for their old_sha1 parameters: * old_sha1 == NULL: Don't check the old value at all. * is_null_sha1(old_sha1): Ensure that the reference didn't exist before the transaction. * otherwise: Ensure that the reference had t