Re: [PATCH v3 14/23] patch-ids.c: remove implicit dependency on the_index

On Mon, Sep 10, 2018 at 8:50 PM Stefan Beller wrote: > > On Sun, Sep 9, 2018 at 1:54 AM Nguyễn Thái Ngọc Duy wrote: > > > > --- > > Junio would have to forge your Sign off here? I _knew_ I missed something in that "git format-patch" command but couldn't figure out what! Will resend (I have to fi

Re: [PATCH v3 14/23] patch-ids.c: remove implicit dependency on the_index

Stefan Beller writes: > On Sun, Sep 9, 2018 at 1:54 AM Nguyễn Thái Ngọc Duy wrote: >> >> --- > > Junio would have to forge your Sign off here? > (I just realize this holds true for the whole series, > but it occurred to me in this patch, as I was looking at > the diff_setup[_done] part on the pr

Re: [PATCH v3 14/23] patch-ids.c: remove implicit dependency on the_index

On Sun, Sep 9, 2018 at 1:54 AM Nguyễn Thái Ngọc Duy wrote: > > --- Junio would have to forge your Sign off here? (I just realize this holds true for the whole series, but it occurred to me in this patch, as I was looking at the diff_setup[_done] part on the previous round.

[PATCH v3 14/23] patch-ids.c: remove implicit dependency on the_index

--- builtin/log.c | 2 +- patch-ids.c | 4 ++-- patch-ids.h | 3 ++- revision.c| 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index 4b602236d6..978fe7c10f 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -914,7 +914,7 @@ static void ge