Re: [PATCH v3 13/21] pack-objects: implement bitmap writing

2013-12-21 Thread Jeff King
On Sat, Dec 07, 2013 at 05:32:43PM +0100, Thomas Rast wrote: > > +pack.writebitmaps:: > > + When true, git will write a bitmap index when packing all > > + objects to disk (e.g., as when `git repack -a` is run). This >^^ > > Doesn't sound right in my ears. Re

Re: [PATCH v3 13/21] pack-objects: implement bitmap writing

2013-12-07 Thread Thomas Rast
Reviewed-by: Thomas Rast You could fix this: > +pack.writebitmaps:: > + When true, git will write a bitmap index when packing all > + objects to disk (e.g., as when `git repack -a` is run). This ^^ Doesn't sound right in my ears. Remove the "as"? > +

[PATCH v3 13/21] pack-objects: implement bitmap writing

2013-11-14 Thread Jeff King
From: Vicent Marti This commit extends more the functionality of `pack-objects` by allowing it to write out a `.bitmap` index next to any written packs, together with the `.idx` index that currently gets written. If bitmap writing is enabled for a given repository (either by calling `pack-object