Re: [PATCH v3 13/13] is_missing_file_error(): work around EINVAL on Windows

2017-05-30 Thread Stefan Beller
On Tue, May 30, 2017 at 4:17 PM, Junio C Hamano wrote: > Stefan Beller writes: >> cc'd people knowledgeable of Windows. > > This has been resolved I think with J6t/Dscho's patch yesterday. > > Thanks. Yeah I saw those patches after reviewing this series. Sorry for the noise, Stefan

Re: [PATCH v3 13/13] is_missing_file_error(): work around EINVAL on Windows

2017-05-30 Thread Junio C Hamano
Stefan Beller writes: > On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano wrote: >> When asked to open/fopen a path, e.g. "a/b:/c", which does not exist >> on the filesystem, Windows (correctly) fails to open it but sets >> EINVAL to errno > > errno to EINVAL (as of now it sounds as if it is a EIN

Re: [PATCH v3 13/13] is_missing_file_error(): work around EINVAL on Windows

2017-05-30 Thread Stefan Beller
On Thu, May 25, 2017 at 8:35 PM, Junio C Hamano wrote: > When asked to open/fopen a path, e.g. "a/b:/c", which does not exist > on the filesystem, Windows (correctly) fails to open it but sets > EINVAL to errno errno to EINVAL (as of now it sounds as if it is a EINVAL = errno, which makes no sens

[PATCH v3 13/13] is_missing_file_error(): work around EINVAL on Windows

2017-05-25 Thread Junio C Hamano
When asked to open/fopen a path, e.g. "a/b:/c", which does not exist on the filesystem, Windows (correctly) fails to open it but sets EINVAL to errno because the pathname has characters that cannot be stored in its filesystem. As this is an expected failure, teach is_missing_file_error() helper ab