Re: [PATCH v3 12/19] initial_ref_transaction_commit(): check for duplicate refs

Michael Haggerty writes: > On 06/22/2015 11:06 PM, Junio C Hamano wrote: > ... >> What I am wondering is if we could turn the safety logic that appear >> here (i.e. no existing refs must be assumed by the set of updates, >> etc.) into an optimization cue and implement this as a special case >> h

Re: [PATCH v3 12/19] initial_ref_transaction_commit(): check for duplicate refs

On 06/22/2015 11:06 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Error out if the ref_transaction includes more than one update for any >> refname. >> >> Signed-off-by: Michael Haggerty >> --- >> refs.c | 11 +++ >> 1 file changed, 11 insertions(+) > > This somehow feels l

Re: [PATCH v3 12/19] initial_ref_transaction_commit(): check for duplicate refs

Michael Haggerty writes: > Error out if the ref_transaction includes more than one update for any > refname. > > Signed-off-by: Michael Haggerty > --- > refs.c | 11 +++ > 1 file changed, 11 insertions(+) This somehow feels like "ehh, I now know better and this function should have bee

[PATCH v3 12/19] initial_ref_transaction_commit(): check for duplicate refs

Error out if the ref_transaction includes more than one update for any refname. Signed-off-by: Michael Haggerty --- refs.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/refs.c b/refs.c index 31661c7..53d9e45 100644 --- a/refs.c +++ b/refs.c @@ -4087,12 +4087,22 @@ int initial_