Re: [PATCH v3 10/13] t4014: stop losing return codes of git commands

2019-08-20 Thread Johannes Sixt
Am 20.08.19 um 09:31 schrieb Denton Liu: > Oops, this should read > > git_version="$(git --version >version && sed "s/.* //"

Re: [PATCH v3 10/13] t4014: stop losing return codes of git commands

2019-08-20 Thread Denton Liu
On Tue, Aug 20, 2019 at 03:19:08AM -0400, Denton Liu wrote: > @@ -808,20 +821,24 @@ test_expect_success 'format-patch > --ignore-if-in-upstream HEAD' ' > git format-patch --ignore-if-in-upstream HEAD > ' > > -git_version="$(git --version | sed "s/.* //")" > +test_expect_success 'get git v

[PATCH v3 10/13] t4014: stop losing return codes of git commands

2019-08-20 Thread Denton Liu
Currently, there are two ways where the return codes of Git commands are lost. The first way is when a command is in the upstream of a pipe. In a pipe, only the return code of the last command is used. Thus, all other commands will have their return codes masked. Rewrite pipes so that there are no