Re: [PATCH v3 1/6] commit-graph: return with errors during write

2019-05-01 Thread Ævar Arnfjörð Bjarmason
On Wed, May 01 2019, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > The write_commit_graph() method uses die() to report failure and > exit when confronted with an unexpected condition. This use of > die() in a library function is incorrect and is now replaced by > error() st

[PATCH v3 1/6] commit-graph: return with errors during write

2019-05-01 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The write_commit_graph() method uses die() to report failure and exit when confronted with an unexpected condition. This use of die() in a library function is incorrect and is now replaced by error() statements and an int return type. Now that we use 'goto cleanup' to jump t