Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-07 Thread Junio C Hamano
SZEDER Gábor writes: >> +test_expect_success "git rebase $@" " >> +... >> +git rebase $@ && >> +... >> +" >> +} >> + >> +test_rebase 'G F E D B A' '' > > It appears that this last empty argument triggers some bug in Bash > v4.2 and older (and on macOS such an old Bash is the d

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-05 Thread SZEDER Gábor
On Fri, Apr 05, 2019 at 10:19:59PM +0200, Johannes Schindelin wrote: > Hi, > > On Fri, 5 Apr 2019, Johannes Schindelin wrote: > > > On Fri, 5 Apr 2019, Johannes Sixt wrote: > > > > > Am 05.04.19 um 19:25 schrieb Denton Liu: > > > > On Fri, Apr 05, 2019 at 04:55:37PM +0200, Johannes Schindelin wro

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-05 Thread Johannes Schindelin
Hi, On Fri, 5 Apr 2019, Johannes Schindelin wrote: > On Fri, 5 Apr 2019, Johannes Sixt wrote: > > > Am 05.04.19 um 19:25 schrieb Denton Liu: > > > On Fri, Apr 05, 2019 at 04:55:37PM +0200, Johannes Schindelin wrote: > > >> On Mon, 1 Apr 2019, Denton Liu wrote: > > >>> +test_rebase() { > > >>> +

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-05 Thread Johannes Schindelin
Hi Hannes & Denton, On Fri, 5 Apr 2019, Johannes Sixt wrote: > Am 05.04.19 um 19:25 schrieb Denton Liu: > > On Fri, Apr 05, 2019 at 04:55:37PM +0200, Johannes Schindelin wrote: > >> On Mon, 1 Apr 2019, Denton Liu wrote: > >>> +test_rebase() { > >>> + expected="$1" && > >>> + shift && > >>> + tes

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-05 Thread Johannes Sixt
Am 05.04.19 um 19:25 schrieb Denton Liu: > On Fri, Apr 05, 2019 at 04:55:37PM +0200, Johannes Schindelin wrote: >> On Mon, 1 Apr 2019, Denton Liu wrote: >>> +test_rebase() { >>> + expected="$1" && >>> + shift && >>> + test_expect_success "git rebase $@" " >>> + git checkout master &

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-05 Thread Denton Liu
On Fri, Apr 05, 2019 at 04:55:37PM +0200, Johannes Schindelin wrote: > Hi Denton, > > On Mon, 1 Apr 2019, Denton Liu wrote: > > > diff --git a/t/t3431-rebase-fork-point.sh b/t/t3431-rebase-fork-point.sh > > new file mode 100755 > > index 00..8e2483b73e > > --- /dev/null > > +++ b/t/t3431-

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-05 Thread Johannes Schindelin
Hi Denton, On Mon, 1 Apr 2019, Denton Liu wrote: > diff --git a/t/t3431-rebase-fork-point.sh b/t/t3431-rebase-fork-point.sh > new file mode 100755 > index 00..8e2483b73e > --- /dev/null > +++ b/t/t3431-rebase-fork-point.sh > @@ -0,0 +1,53 @@ > +#!/bin/sh > +# > +# Copyright (c) 2019 Dento

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-05 Thread SZEDER Gábor
On Mon, Apr 01, 2019 at 01:51:57PM -0700, Denton Liu wrote: > Signed-off-by: Denton Liu > --- > t/t3431-rebase-fork-point.sh | 53 > 1 file changed, 53 insertions(+) > create mode 100755 t/t3431-rebase-fork-point.sh > > diff --git a/t/t3431-rebase-fork-point

Re: [PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-04 Thread Denton Liu
On Mon, Apr 01, 2019 at 01:51:57PM -0700, Denton Liu wrote: > Signed-off-by: Denton Liu > --- > t/t3431-rebase-fork-point.sh | 53 > 1 file changed, 53 insertions(+) > create mode 100755 t/t3431-rebase-fork-point.sh > > diff --git a/t/t3431-rebase-fork-point

[PATCH v3 1/4] t3431: add rebase --fork-point tests

2019-04-01 Thread Denton Liu
Signed-off-by: Denton Liu --- t/t3431-rebase-fork-point.sh | 53 1 file changed, 53 insertions(+) create mode 100755 t/t3431-rebase-fork-point.sh diff --git a/t/t3431-rebase-fork-point.sh b/t/t3431-rebase-fork-point.sh new file mode 100755 index 00..