Re: [PATCH v3 1/4] serialize collection of changed submodules

2016-11-15 Thread Stefan Beller
On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt wrote: > @@ -560,6 +575,31 @@ static void find_unpushed_submodule_commits(struct > commit *commit, > diff_tree_combined_merge(commit, 1, &rev); > } > > +struct collect_submodule_from_sha1s_data { > + char *submodule_path; > + stru

[PATCH v3 1/4] serialize collection of changed submodules

2016-11-15 Thread Heiko Voigt
To check whether a submodule needs to be pushed we need to collect all changed submodules. Lets collect them first and then execute the possibly expensive test whether certain revisions are already pushed only once per submodule. There is further potential for optimization since we can assemble on