Re: [PATCH v3 1/2] auto gc: don't write bitmaps for incremental repacks

2016-12-23 Thread Jeff King
On Fri, Dec 23, 2016 at 08:08:54PM -0500, David Turner wrote: > + git gc --auto 2>err && > + test_i18ngrep ! "^warning:" err && > + ls .git/objects/pack/ | grep -v bitmap | sort >post_packs && I'm not sure why you omit the bitmap here. It shouldn't change, right? In that case it shoul

[PATCH v3 1/2] auto gc: don't write bitmaps for incremental repacks

2016-12-23 Thread David Turner
When git gc --auto does an incremental repack of loose objects, we do not expect to be able to write a bitmap; it is very likely that objects in the new pack will have references to objects outside of the pack. So we shouldn't try to write a bitmap, because doing so will likely issue a warning. T