Re: [PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-11 Thread Torsten Bögershausen
> > Can you please replace the rather unnecessary, very, very long > `win_path_utils_` function name prefix by the much better prefix `win32_`, > to keep in line with the current, already existing, surrounding files' > convention? Thanks a bunch. > That makes sense - thanks for the suggestion &

Re: [PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-11 Thread Johannes Schindelin
Hi Torsten, On Tue, 11 Dec 2018, Torsten Bögershausen wrote: > On Mon, Dec 10, 2018 at 09:32:03AM +0100, Johannes Schindelin wrote: > > > > On Sat, 8 Dec 2018, tbo...@web.de wrote: > > > > > And, before any cleanup is done, I sould like to ask if anybody > > > can build the code with VS and con

Re: [PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-10 Thread Torsten Bögershausen
On Mon, Dec 10, 2018 at 09:32:03AM +0100, Johannes Schindelin wrote: > Hi Torsten, > > On Sat, 8 Dec 2018, tbo...@web.de wrote: > > > And, before any cleanup is done, I sould like to ask if anybody > > can build the code with VS and confirm that it works, please ? > > Can you give me an easy-to-

Re: [PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-10 Thread Johannes Schindelin
Hi Torsten, On Sat, 8 Dec 2018, tbo...@web.de wrote: > And, before any cleanup is done, I sould like to ask if anybody > can build the code with VS and confirm that it works, please ? Can you give me an easy-to-fetch branch? Thanks, Dscho

Re: [PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-08 Thread Junio C Hamano
tbo...@web.de writes: > - The "DOS" moniker is still used for 2 reasons: > Windows inherited the "drive letter" concept from DOS, > and everybody (tm) familar with the code and the path handling > in Git is used to that wording. Yeah, for the same reason as win32 can refer to their API that

Re: [PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-08 Thread Steven Penny
On Sat, Dec 8, 2018 at 9:11 AM wrote: > Changes since V2: latest patch still fixes original issue - thanks > - Settled on a better name: > The common code is in compat/win32/path-utils.c/h > [...] > - The "DOS" moniker is still used for 2 reasons: > Windows inherited the "drive letter" conc

[PATCH v3 1/1] git clone C:\cygwin\home\USER\repo' is working (again)

2018-12-08 Thread tboegi
From: Torsten Bögershausen A regression for cygwin users was introduced with commit 05b458c, "real_path: resolve symlinks by hand". In the the commit message we read: The current implementation of real_path uses chdir() in order to resolve symlinks. Unfortunately this isn't thread-safe a