Re: [PATCH v3 08/16] pathspec: always show mnemonic and name in unsupported_magic

2017-01-03 Thread Brandon Williams
On 01/03, Duy Nguyen wrote: > On Wed, Dec 14, 2016 at 6:14 AM, Brandon Williams wrote: > > @@ -340,8 +336,9 @@ static void NORETURN unsupported_magic(const char > > *pattern, > > continue; > > if (sb.len) > > strbuf_addch(&sb, ' ');

Re: [PATCH v3 08/16] pathspec: always show mnemonic and name in unsupported_magic

2017-01-03 Thread Duy Nguyen
On Wed, Dec 14, 2016 at 6:14 AM, Brandon Williams wrote: > @@ -340,8 +336,9 @@ static void NORETURN unsupported_magic(const char > *pattern, > continue; > if (sb.len) > strbuf_addch(&sb, ' '); > - if (short_magic & m->b

[PATCH v3 08/16] pathspec: always show mnemonic and name in unsupported_magic

2016-12-13 Thread Brandon Williams
For better clarity, always show the mnemonic and name of the unsupported magic being used. This lets users have a more clear understanding of what magic feature isn't supported. And if they supplied a mnemonic, the user will be told what its corresponding name is which will allow them to more eas