Célestin Matte writes:
> Le 11/06/2013 20:09, Junio C Hamano a écrit :
>> Matthieu Moy writes:
>>
my ($namespace) = @_;
my $namespace = shift;
My impression has been that both are equally common,
>>>
>>> The second is the most common in git-remote-mediawiki (but I d
Le 11/06/2013 20:09, Junio C Hamano a écrit :
> Matthieu Moy writes:
>
>>> my ($namespace) = @_;
>>> my $namespace = shift;
>>>
>>> My impression has been that both are equally common,
>>
>> The second is the most common in git-remote-mediawiki (but I don't have
>> any preference nor kn
Matthieu Moy writes:
>> my ($namespace) = @_;
>> my $namespace = shift;
>>
>> My impression has been that both are equally common,
>
> The second is the most common in git-remote-mediawiki (but I don't have
> any preference nor know what is recommended elsewhere).
I wasn't implying I
Junio C Hamano writes:
> Célestin Matte writes:
>
>> Subroutines' parameters should be affected to variable before doing anything
>> else
>> Besides, existing instruction affected a variable inside a "if", which break
>> Git's coding style
>
> I think s/affect/assign/g is what you meant.
Yes, c
Célestin Matte writes:
> Subroutines' parameters should be affected to variable before doing anything
> else
> Besides, existing instruction affected a variable inside a "if", which break
> Git's coding style
I think s/affect/assign/g is what you meant.
By the way, I often see two styles of the
Subroutines' parameters should be affected to variable before doing anything
else
Besides, existing instruction affected a variable inside a "if", which break
Git's coding style
Signed-off-by: Célestin Matte
Signed-off-by: Matthieu Moy
---
contrib/mw-to-git/git-remote-mediawiki.perl |3 ++-
6 matches
Mail list logo
