Re: [PATCH v3 07/14] apply: make parse_git_header public

On 07/09, Junio C Hamano wrote: > Thomas Gummerer writes: > > > Maybe it would be even better to name it 'struct gitdiff_data', as > > it's really only used for those few functions? > > Is it really the case where "these three are only used by the > codepath you made public"? If so, I agree tha

Re: [PATCH v3 07/14] apply: make parse_git_header public

Thomas Gummerer writes: > Maybe it would be even better to name it 'struct gitdiff_data', as > it's really only used for those few functions? Is it really the case where "these three are only used by the codepath you made public"? If so, I agree that "gitdiff_data" is a perfectly good name for

Re: [PATCH v3 07/14] apply: make parse_git_header public

On 07/09, Junio C Hamano wrote: > Thomas Gummerer writes: > > > Make parse_git_header a "public" function in apply.h, so we can re-use > > it in range-diff in a subsequent commit. Eek, I just noticed that I forgot updating the name here. This and the Subject should say 'parse_git_diff_header()'

Re: [PATCH v3 07/14] apply: make parse_git_header public

Thomas Gummerer writes: > Make parse_git_header a "public" function in apply.h, so we can re-use > it in range-diff in a subsequent commit. > > Signed-off-by: Thomas Gummerer > --- Thanks for these refactoring patches on "apply" machinery in the early part of the series. I noticed two small th

[PATCH v3 07/14] apply: make parse_git_header public

Make parse_git_header a "public" function in apply.h, so we can re-use it in range-diff in a subsequent commit. Signed-off-by: Thomas Gummerer --- apply.c | 69 - apply.h | 48 +++ 2 files changed, 67 ins