Re: [PATCH v3 07/10] submodule: check for unstaged .gitmodules outside of config parsing

2017-08-02 Thread Brandon Williams
On 08/02, Brandon Williams wrote: > On 07/31, Stefan Beller wrote: > > > > So this is where the check "pos < active_nr" is coming from, > > introduced in 5fee995244 (submodule.c: add .gitmodules staging > > helper functions, 2013-07-30) as well as d4e98b581b (Submodules: > > Don't parse .gitmodule

Re: [PATCH v3 07/10] submodule: check for unstaged .gitmodules outside of config parsing

2017-08-02 Thread Brandon Williams
On 07/31, Stefan Beller wrote: > On Tue, Jul 18, 2017 at 12:05 PM, Brandon Williams wrote: > > Teach 'is_staging_gitmodules_ok()' to be able to determine in the > > '.gitmodules' file has unstaged changes based on the passed in index > > instead of relying on a global varible which is set during t

Re: [PATCH v3 07/10] submodule: check for unstaged .gitmodules outside of config parsing

2017-07-31 Thread Stefan Beller
On Tue, Jul 18, 2017 at 12:05 PM, Brandon Williams wrote: > Teach 'is_staging_gitmodules_ok()' to be able to determine in the > '.gitmodules' file has unstaged changes based on the passed in index > instead of relying on a global varible which is set during the variable > submodule-config parsin

[PATCH v3 07/10] submodule: check for unstaged .gitmodules outside of config parsing

2017-07-18 Thread Brandon Williams
Teach 'is_staging_gitmodules_ok()' to be able to determine in the '.gitmodules' file has unstaged changes based on the passed in index instead of relying on a global varible which is set during the submodule-config parsing. Signed-off-by: Brandon Williams --- builtin/mv.c | 2 +- builtin/rm.c |