Re: [PATCH v3 06/28] connect.c: teach get_remote_heads to parse "shallow" lines

2013-11-27 Thread Duy Nguyen
On Tue, Nov 26, 2013 at 5:42 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Perhaps a preparatory patch needs to rename the structure type to >> object_name_list or something. And then we can make the variable >> names, not typenames, responsible for signalling what they mean, >> i.e. >

Re: [PATCH v3 06/28] connect.c: teach get_remote_heads to parse "shallow" lines

2013-11-25 Thread Junio C Hamano
Junio C Hamano writes: > Perhaps a preparatory patch needs to rename the structure type to > object_name_list or something. And then we can make the variable > names, not typenames, responsible for signalling what they mean, > i.e. > > get_remote_heads(... > struct list_of_ob

Re: [PATCH v3 06/28] connect.c: teach get_remote_heads to parse "shallow" lines

2013-11-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > No callers pass a non-empty pointer as shallow_points at this > stage. As a result, all clients still refuse to talk to shallow > repository on the other end. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/fetch-pack.c | 2 +- > builtin/send-pack.c |

[PATCH v3 06/28] connect.c: teach get_remote_heads to parse "shallow" lines

2013-11-24 Thread Nguyễn Thái Ngọc Duy
No callers pass a non-empty pointer as shallow_points at this stage. As a result, all clients still refuse to talk to shallow repository on the other end. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/fetch-pack.c | 2 +- builtin/send-pack.c | 2 +- connect.c| 12 +++- r